Sundry fixes #747
Merged
Sundry fixes #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aprillion
approved these changes
Jul 16, 2024
| searchFn(query) | ||
| setShowResults(true) | ||
| } | ||
| // Properly adding all dependancies would require transforming `searchFn` into a callback |
There was a problem hiding this comment.
from phone, but something like:
const searchFnRef = useRef(searchFn)
searchFnRef.current = searchFn
useEffect(
...searchFnRef.current(),
...There was a problem hiding this comment.
dunno if that's better... :D
There was a problem hiding this comment.
disabling the eslint rule is unsafe for future changes which can more easily introduce bugs.. mutable refs might not look good, but you explicitly say "this is not a dependency which triggers a synchronization, I just want to use whatever value is has currently" without implying anything about any other variable that may or may not be a dependency
| @@ -25,4 +25,4 @@ MATOMO_DOMAIN = "{MATOMO_DOMAIN}" | |||
| DISCORD_LOGGING_CHANNEL_ID = "{DISCORD_LOGGING_CHANNEL_ID}" | |||
| DISCORD_LOGGING_TOKEN = "{DISCORD_LOGGING_TOKEN}" | |||
| EDITOR_USERNAME = "{EDITOR_USERNAME}" | |||
| EDITOR_PASSWORD = "{EDITOR_PASSWORD}" | |||
| EDITOR_PASSWORD = "{EDITOR_PASSWORD}" | |||
There was a problem hiding this comment.
trailing whitespace
LeMurphant
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g.